Support coo_matrix in coo_symmetrize and coo_remove_scalar
#2662
+182
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aamijar
added
non-breaking
aamijar
commented
May 13, 2025
| */ | ||
| template <int TPB_X, typename T, typename idx_t, typename nnz_t> | ||
| void coo_remove_scalar_mytest(raft::device_coo_matrix_view<T, idx_t, idx_t, nnz_t> in, | ||
| raft::device_coo_matrix<T, idx_t, idx_t, nnz_t>& out, |
There was a problem hiding this comment.
Is it possible to make this a device_coo_matrix_view ? Problem is that I can't call out.initialize_sparsity(out_nnz) if its a view.
aamijar
commented
May 13, 2025
| */ | ||
| template <int TPB_X = 128, typename T, typename IdxT, typename nnz_t, typename Lambda> | ||
| void coo_symmetrize_mytest(raft::device_coo_matrix_view<T, IdxT, IdxT, nnz_t> in, | ||
| raft::device_coo_matrix_view<T, IdxT, IdxT, nnz_t> out, |
There was a problem hiding this comment.
Probably change this to a ref and lazily allocate out inside this function with out.initialize_sparsity(out_nnz)
aamijar
commented
May 14, 2025
| * @param stream: cuda stream to use | ||
| */ | ||
| template <int TPB_X = 128, typename T, typename IdxT, typename nnz_t, typename Lambda> | ||
| void coo_symmetrize_mytest(raft::device_coo_matrix_view<T, IdxT, IdxT, nnz_t> in, |
There was a problem hiding this comment.
Todo: add the public function in non detail file
There was a problem hiding this comment.
Todo: rename function name from mytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2656, Resolves #2659