-
Notifications
You must be signed in to change notification settings - Fork 20
Replace all -F
usage with -f
#350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all -F
usage with -f
#350
Conversation
@jarmak-nv before we merge... I noticed this was targeted at the It does looks like there are some lingering references to the I've retargeted this at
And then I think the deployment story should be:
|
I think there's some confusion in part because it's going to be a bit before all the repos are using the same branch of shared-workflows anyway at this point, and I'm the one asking Ben for these workflow fixes that are blocking cudf's board automations (I don't think any other repo is using them, or at least not to the same extent) but cudf is lagging in some of the migrations due to e.g. the CUDA 12.9 compiler issues. Let's stick with James's suggestion for the merge plan. Worst case we need to merge down branch-25.06 into one of the migration branch sooner for more testing. |
861fe12
to
27ae5ad
Compare
Should be g2g Will note cuML also uses these, currently pinned to branch-25.06. |
@jameslamb - when you're on, any thoughts on this CI failure?
Pre-commit linting passes on my end, but maybe I broke something? 😅 |
@jarmak-nv -- this looks like the recently added |
Sorry! I didn’t realize that hook required Docker. I just copied it from rapidsai/shared-actions. Perhaps we need to disable it in CI, or run in our own infrastructure. |
I'll push up a commit disabling it for now -- I think we can run it on our own infrastructure but I need to familiarize myself with how we run workflows within shared-workflows |
Ok, disabled it for CI only, so it'll still run locally. Going to merge this now |
Thanks @jarmak-nv ! |
Thanks all! Appreciate the support 🚀 |
This pull request updates multiple GitHub Actions workflows to standardize the usage of the
gh api graphql
command by replacing the-F
flag with the-f
flag for all GraphQL variable inputs. This change ensures consistency and aligns with best practices for thegh
CLI.From GitHub
I'm unsure if this is a recent change, but we hit the failure when attempting to convert an integer into a string. GitHub may silently fix string-likes.
targeting python3.13 as cuDF found the failure; can merge to main after confirmation of resolution.