Merge conda-forge/main into rapidsai/main (pt. 15)
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuild packages with `string_prefix` pinning alignment across packages.
automerged PR by conda-forge/automerge-action
hcho3
approved these changes
Jul 31, 2024
jakirkham
commented
Jul 31, 2024
There was a problem hiding this comment.
Noticed we had some lingering patches here, but we don't actually apply them
xgboost-feedstock/recipe/meta.yaml
Lines 13 to 16 in ad107c2
Plus they have all been upstreamed (as noted below). So dropping them
| @@ -1,32 +0,0 @@ | |||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | |||
There was a problem hiding this comment.
Upstreamed in PR: dmlc/xgboost#9436
| @@ -1,82 +0,0 @@ | |||
| From 2e1d276e925992fd4faf310b20be83680f329bf1 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Upstreamed in PR: dmlc/xgboost#9602
| @@ -1,46 +0,0 @@ | |||
| diff --git a/python-package/xgboost/data.py b/python-package/xgboost/data.py | |||
There was a problem hiding this comment.
Upstreamed in PR: dmlc/xgboost#10175
dantegd
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string_prefixacross dependencies conda-forge/xgboost-feedstock#188