feat(dockercache): add registry blob storage option #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptadev21
added
the
type/feature ✨
|
🤖 Pull Request Artifacts (#15587754117) 🎉 |
guptadev21
force-pushed
the
feat/registry-blobstorage
branch
from
615eac1 to
74de440
Compare
guptadev21
force-pushed
the
feat/registry-blobstorage
branch
2 times, most recently
from
dde2dc4 to
481dd5f
Compare
ankitrgadiya
requested changes
Jun 6, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
guptadev21
force-pushed
the
feat/registry-blobstorage
branch
from
481dd5f to
9602b50
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable registry blob storage path for the Docker cache feature.
- Introduces a new
--data-directoryCLI option and corresponding parameter in the API payload - Updates the JSON schema to include
dataDirectorywith a default value - Adds
dataDirectoryto the example manifest and docstring
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| riocli/project/features/dockercache.py | Added --data-directory option, updated function signature, payload, and usage example |
| riocli/jsonschema/schemas/project-schema.yaml | Defined dataDirectory property with default in the project schema |
| riocli/apply/manifests/project.yaml | Included dataDirectory default in the example project manifest |
Comments suppressed due to low confidence (2)
riocli/project/features/dockercache.py:85
- [nitpick] The usage example path (
/tmp/rapyuta/volumes) doesn’t match the CLI’s default (/opt/rapyuta/volumes/docker-cache/). Update the example to reflect the intended default structure or clarify it’s just an arbitrary path.
--data-directory "/tmp/rapyuta/volumes"
riocli/project/features/dockercache.py:55
- You’ve added a new
--data-directoryoption but there are no accompanying tests. Consider adding unit tests to verify that the flag is parsed correctly and the payload includesdataDirectory.
@click.option(
Co-authored-by: Copilot <[email protected]>
ankitrgadiya
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/rapyuta-robotics/rapyuta_io/issues/742