Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Please see ch05/05_bonus_hparam_tuning/hparam_search.py
|
|
ch05/05_bonus_hparam_tuning/previous_chapters.py Unexpected keyword argument class GPTDatasetV1(Dataset):
def __init__(self, txt, tokenizer, max_length, stride): |
|
appendix-E/01_main-chapter-code/previous_chapters.py keyword arg |
|
|
|
Thanks for the PR. And the CI failure is weird, I'll try to restart. |
rasbt
left a comment
There was a problem hiding this comment.
Looks really good to me, thanks a lot!
|
I think the hparam Btw. great catch regarding the redundant |
|
Thanks a lot for checking and updating the code! |
* updated .gitignore * removed unused GELU import * fixed model_configs, fixed all tensors on same device * removed unused tiktoken * update * update hparam search * remove redundant tokenizer argument --------- Co-authored-by: rasbt <[email protected]>
GELU()is inFeedForward()func)tiktokennot used)Please also see below comments, there are some issues that you might need to take a look into