Skip to content

Simplify embedding vs linear layer code#278

Merged
rasbt merged 1 commit intomainfrom
simplify-embedding
Jul 21, 2024
Merged

Simplify embedding vs linear layer code#278
rasbt merged 1 commit intomainfrom
simplify-embedding

Conversation

@rasbt
Copy link
Owner

@rasbt rasbt commented Jul 21, 2024

Removes a redundant .detach() in the code as discussed in #277

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rasbt rasbt merged commit fa56c80 into main Jul 21, 2024
@rasbt rasbt deleted the simplify-embedding branch July 21, 2024 17:21
rasbt added a commit that referenced this pull request Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant