47,678-->48,725 #281
Merged
47,678-->48,725 #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if I not misunderstand, should it be the vocab size? the probability distribute across the whole vocab and sum to 1. Each step has the number of vocab's size choice.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Good catch! I updated it in the book itself but totally forgot to update it in the notes, too. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if I not misunderstand, should it be the vocab size? the probability distribute across the whole vocab and sum to 1. Each step has the number of vocab's size choice.the number
47,678or47678can't be found in context, so I think maybe it's a misspelled number. Given the context of effective vocabulary size, and ppl is 48725.8203, should it be 48,725?