Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed command for row 16 additional experiment #439

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Fixed command for row 16 additional experiment #439

merged 2 commits into from
Nov 16, 2024

Conversation

d-kleine
Copy link
Contributor

  • fixed command for running the row 16 experiment in the additional experiments for selecting the last non-padding token position for training (last_token_pos isn't a valid arg, therefore results in an error).

@d-kleine d-kleine marked this pull request as ready for review November 16, 2024 18:01
rasbt
rasbt approved these changes Nov 16, 2024
View reviewed changes
Copy link
Owner

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@rasbt rasbt merged commit e95c898 into rasbt:main Nov 16, 2024
3 checks passed
@d-kleine d-kleine deleted the addexp_fix_flex branch November 16, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasbt rasbt rasbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-kleine @rasbt