-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix BPE bonus materials #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@rasbt About the lowest possible merge rank defined as LLMs-from-scratch/ch02/05_bpe-from-scratch/bpe-from-scratch.ipynb Lines 607 to 613 in f63f04d
|
yes, I agree! |
Fixes issues with the BPE tokenizer to correctly handle edge cases.
Fixes #558