Skip to content

updated exercise 5.3 #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2025
Merged

updated exercise 5.3 #615

merged 3 commits into from
Apr 13, 2025

Conversation

henrythe9th
Copy link
Contributor

temperature can be set to 0 to regardless of top_k setting to force deterministic behavior

temperature can be set to 0 to regardless of top_k setting to force deterministic behavior
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rasbt
Copy link
Owner

rasbt commented Apr 13, 2025

Good catch, you are correct, that was a bit unclear. It said

Setting to top_k=None and applying no temperature scaling;

but your version (temperature=0.0) is much simpler and easier to understand. Thanks!!

@rasbt rasbt merged commit 02779f5 into rasbt:main Apr 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants