Add association between DRM panels and backlight where defined #6177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shutdown and remove hooks so that the panel gets powered off with the system. Signed-off-by: Dave Stevenson <[email protected]>
As with many microcontrollers, the panel wants to use clock stretching during a read so that the appropriate return value can be generated and programmed into the hardware. With Pi0-3 really not supporting clock stretching, this resulted in the panel firmware dying. Insert a delay between the write and the read to give the firmware a chance to generate the relevant return value. Signed-off-by: Dave Stevenson <[email protected]>
The naming of backlight devices is not terribly useful for associating a backlight controller with a display (assuming it is attached to one). Add a sysfs node that will return a display name that can be set by other subsystems. Signed-off-by: Dave Stevenson <[email protected]>
Pass the DRM connector name to any configured backlight device so that userspace can associate the two items. Ideally this should be in drm_panel, but it is bridge/panel that creates the drm_connector and therefore knows the name. Signed-off-by: Dave Stevenson <[email protected]>
|
@pelwell @popcornmix |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comment from SimonL for UI backlight control.
For ease of testing this also includes the patches from 6176 as it's useful to have the panel fully working.