ARM: dts: Fix camera sync parameters #6184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The camera sync parameter declarations include are invalid in that they have both embedded string values and following cell values. The intention here was to use the cell values, but the embedded "0" was not removed as it should have been. The implication of this mistake is that inverted sync flags would be ignored because the 0 value corresponds to GPIO_ACTIVE_HIGH. The extra cell value would be treated as the start of another override, but then ignored because the end of the parameter is reached. These errors should have been picked up by the automated checks, but the base dts files weren't subjected to the same validation. This has now been corrected. Signed-off-by: Phil Elwell <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera sync parameter declarations include are invalid in that they have both embedded string values and following cell values. The intention here was to use the cell values, but the embedded "0" was not removed as it should have been.
The implication of this mistake is that inverted sync flags would be ignored because the 0 value corresponds to GPIO_ACTIVE_HIGH. The extra cell value would be treated as the start of another override, but then ignored because the end of the parameter is reached.
These errors should have been picked up by the automated checks, but the base dts files weren't subjected to the same validation. This has now been corrected.