dts: bcm2712-rpi: Move rpi-otp nodes onto a bus #6197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the rpi-otp nodes in |
|
No, not really - I can give them the same treatment. |
The rpi-otp driver uses a virtualised, OTP-relative addressing scheme. However, when instance nodes are children of "/soc" they appear to be addressable directly by the host, which is wrong (but not in a way which causes an error unless one goes looking for one). Add a wrapper (bus) node without a "ranges" property to make the separation clear. See: raspberrypi#6196 Signed-off-by: Phil Elwell <[email protected]>
|
Like so. |
popcornmix
approved these changes
May 30, 2024
|
@pelwell, thank you. I checked your PR on my setup, it is working as expected, i.e. Xen is happy. |
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 7, 2024
kernel: configs: enable CONFIG_NET_FOU_IP_TUNNELS See: raspberrypi/linux#6204 kernel: dts: bcm2712-rpi: Move rpi-otp nodes onto a bus See: raspberrypi/linux#6197 kernel: vc4/hdmi: Fix Hsync and Vsync polarity changes See: raspberrypi/linux#6193 kernel: Update DAC8x to support 384khz See: raspberrypi/linux#6187 kernel: DTS: overlays: add mmio-hi parameter to pciex1-compat-pi5 See: raspberrypi/linux#6186
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 12, 2024
kernel: configs: enable CONFIG_NET_FOU_IP_TUNNELS See: raspberrypi/linux#6204 kernel: dts: bcm2712-rpi: Move rpi-otp nodes onto a bus See: raspberrypi/linux#6197 kernel: vc4/hdmi: Fix Hsync and Vsync polarity changes See: raspberrypi/linux#6193 kernel: Update DAC8x to support 384khz See: raspberrypi/linux#6187 kernel: DTS: overlays: add mmio-hi parameter to pciex1-compat-pi5 See: raspberrypi/linux#6186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rpi-otp driver uses a virtualised, OTP-relative addressing scheme. However, when instance nodes are children of "/soc" they appear to be addressable directly by the host, which is wrong (but not in a way which causes an error unless one goes looking for one).
Add a wrapper (bus) node without a "ranges" property to make the separation clear.
See: #6196