Fix the IQaudIO handling of 16-bit samples #6215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following [1], it becomes harder for the CPU DAI to know the correct BCLK ratio. We can either bake the same knowledge into the sound card driver, or implement and use set_bclk_ratio on the codec. This commit does the latter. [1] commit c89e652 ("ASoC: da7213: Add support for mono, set frame width to 32 when possible") Signed-off-by: Phil Elwell <[email protected]>
To ensure that the CPU DAI and codec agree over the BCLK ratio, impose a fixed value of 64 on both of them. Signed-off-by: Phil Elwell <[email protected]>
|
This is said patch: c89e652 |
|
LGTM |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 12, 2024
kernel: Fix HS400 on CM5 See: raspberrypi/linux#6203 kernel: Reinstate "output format" DRM property See: raspberrypi/linux#6133 kernel: Fix the IQaudIO handling of 16-bit samples See: raspberrypi/linux#6215
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 12, 2024
kernel: Fix HS400 on CM5 See: raspberrypi/linux#6203 kernel: Reinstate "output format" DRM property See: raspberrypi/linux#6133 kernel: Fix the IQaudIO handling of 16-bit samples See: raspberrypi/linux#6215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between rpi-6.1.y and rpi-6.6.y the DA7213 codec driver picked up a patch selecting a BCLK ratio of 32 for 16-bit audio. This breaks the CPU DAI if it is expecting a BCLK ratio of 64. Instead of baking the knowledge of the codec's foibles into the soundcard driver, give the codec a set_bclk_ratio method and make the soundcard driver use it.