drm/probe-helper: Ensure cmdline mode matches interlace mode #6902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
reviewed
Jun 16, 2025
drm_helper_probe_add_cmdline_mode was looking for a match for the width, height, and refresh rate within the EDID modes, but didn't check the interlacing flag. That meant that with video=1920x1080@50i would match any 1920x1080@50 mode that was found. The converse would be possible too if an interlaced mode with matching resolution & refresh rate was found first. Check the interlacing flag as well. Signed-off-by: Dave Stevenson <[email protected]>
popcornmix
approved these changes
Jun 16, 2025
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 18, 2025
See: raspberrypi/linux#6891 kernel: Fix dwc2 thinkos See: raspberrypi/linux#6906 kernel: dts: cm5/pi5: Disable EEE on rp1 See: raspberrypi/linux#6900 kernel: GPIO Acquire/Release Semantics for 'AI Camera' See: raspberrypi/linux#6884 kernel: configs: arm64: Enable the UDMABUF driver See: raspberrypi/linux#6903 kernel: drm/probe-helper: Ensure cmdline mode matches interlace mode See: raspberrypi/linux#6902 kernel: media: i2c: Tweak default PDAF gain table in imx708 driver See: raspberrypi/linux#6901 kernel: drivers: media: imx500: Add device id readback control See: raspberrypi/linux#6897 kernel: overlays: i2c-rtc: Add M41T80 support
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 18, 2025
See: raspberrypi/linux#6891 kernel: Fix dwc2 thinkos See: raspberrypi/linux#6906 kernel: dts: cm5/pi5: Disable EEE on rp1 See: raspberrypi/linux#6900 kernel: GPIO Acquire/Release Semantics for 'AI Camera' See: raspberrypi/linux#6884 kernel: configs: arm64: Enable the UDMABUF driver See: raspberrypi/linux#6903 kernel: drm/probe-helper: Ensure cmdline mode matches interlace mode See: raspberrypi/linux#6902 kernel: media: i2c: Tweak default PDAF gain table in imx708 driver See: raspberrypi/linux#6901 kernel: drivers: media: imx500: Add device id readback control See: raspberrypi/linux#6897 kernel: overlays: i2c-rtc: Add M41T80 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drm_helper_probe_add_cmdline_mode was looking for a match for the width, height, and refresh rate within the EDID modes, but didn't check the interlacing flag. That meant that with video=1920x1080@50i would match any 1920x1080@50 mode that was found.
The converse would be possible too if an interlaced mode with matching resolution & refresh rate was found first.
Check the interlacing flag as well.
raspberrypi/bookworm-feedback#422