Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed population of PICO_EXTRAS_PATH when fetched from git #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix failed population of PICO_EXTRAS_PATH when fetched from git #43

wants to merge 1 commit into from

Conversation

ithinuel
Copy link

When running cmake with

cmake -B build -DPICO_SDK_FETCH_FROM_GIT=y -DPICO_EXTRAS_FETCH_FROM_GIT=y

configuration fails because PICO_EXTRAS_PATH incorrectly points to build rather than build/_deps/pico_extras-src.

@ithinuel
Fix failed population of PICO_EXTRAS_PATH when fetched from git
54116f5 
When running cmake with
```
cmake -B build -DPICO_SDK_FETCH_FROM_GIT=y -DPICO_EXTRAS_FETCH_FROM_GIT=y
```

configuration fails because `PICO_EXTRAS_PATH` incorrectly points to
`build` rather than `build/_deps/pico_extras-src`.
@ithinuel
Copy link
Author

gentle ping @lurch for a review

@lurch
Copy link
Contributor

lurch commented Oct 20, 2023

Thanks for the nudge, but I'm not directly working on Pico-related stuff any more, so it's not up to me to review or merge this PR.

@ithinuel
Copy link
Author

Thank you for your reply. Based on the git history and the profiles' contribution, I guess the next canditate is @kilograham ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithinuel @lurch