Remove rate limit warning

Signed-off-by: paulober <[email protected]>
raspberrypi · Sep 12, 2024 · a1de07c · a1de07c
1 parent 0a8ea76
commit a1de07c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 37 deletions.
diff --git a/src/utils/download.mts b/src/utils/download.mts
@@ -433,7 +433,7 @@ async function downloadAndInstallGithubAsset(
     existsSync(targetDirectory) &&
     readdirSync(targetDirectory).length !== 0
   ) {
-    Logger.info(
+    Logger.debug(
       LoggerSource.downloader,
       `${logName} ${version} is already installed.`
     );

diff --git a/src/utils/githubREST.mts b/src/utils/githubREST.mts
@@ -5,7 +5,7 @@ import GithubApiCache, {
 } from "./githubApiCache.mjs";
 import { type RequestOptions, request } from "https";
 import { unknownErrorToString, unknownToError } from "./errorHelper.mjs";
-import { env, Uri, window } from "vscode";
+import { window } from "vscode";
 
 // TODO: move into web consts
 export const HTTP_STATUS_OK = 200;
@@ -249,11 +249,9 @@ async function getReleases(repository: GithubRepository): Promise<string[]> {
 
       return getReleases(repository);
     } else if (response.status === HTTP_STATUS_FORBIDDEN) {
-      githubApiForbidden();
-
       // return the default response as without a PAT
       // ther is no way a rerun will succeed in the near future
-      throw new Error("GitHub API Code 403 Forbidden");
+      throw new Error("GitHub API Code 403 Forbidden. Rate limit exceeded.");
     } else if (response.status !== 200) {
       throw new Error("Error http status code: " + response.status);
     }
@@ -367,11 +365,9 @@ export async function getGithubReleaseByTag(
 
       return getGithubReleaseByTag(repository, tag);
     } else if (response.status === HTTP_STATUS_FORBIDDEN) {
-      githubApiForbidden();
-
       // return the default response as without a PAT
       // ther is no way a rerun will succeed in the near future
-      throw new Error("GitHub API Code 403 Forbidden");
+      throw new Error("GitHub API Code 403 Forbidden. Rate limit exceeded.");
     } else if (response.status !== 200) {
       throw new Error("Error http status code: " + response.status);
     }
@@ -431,32 +427,3 @@ export async function githubApiUnauthorized(): Promise<void> {
   );
   await Settings.getInstance()?.updateGlobal(SettingsKey.githubToken, "");
 }
-
-/**
- * Show rate limit exceeded warning to the user.
- */
-export function githubApiForbidden(): void {
-  Logger.warn(
-    LoggerSource.githubRestApi,
-    "GitHub API Code 403 Forbidden. Probably rate limit exceeded."
-  );
-  // show a rate limit warning to the user
-  void window
-    .showWarningMessage(
-      "GitHub API rate limit exceeded. Please try again later." +
-        "Consider adding a GitHub Personal Access Token in the settings " +
-        "to increase your rate limit.",
-      "More Info"
-    )
-    .then(selection => {
-      if (selection === "More Info") {
-        env.openExternal(
-          Uri.parse(
-            "https://github.com/raspberrypi/pico-vscode" +
-              "/?tab=readme-ov-file#github-api-rate-limit-error-" +
-              "while-retrieving-sdk-and-toolchain-versions"
-          )
-        );
-      }
-    });
-}