Conversation
This was referenced Aug 15, 2024
atanisoft
reviewed
Aug 16, 2024
| ``` | ||
| git -c advice.detachedHead=false clone --branch <sdk_version> https://github.com/raspberrypi/pico-sdk.git "~/.pico-sdk/sdk/<sdk_version>" | ||
| cd "~/.pico-sdk/sdk/<sdk_version>" | ||
| git submodule update --init |
There was a problem hiding this comment.
instead of a dedicated step here, perhaps add --recursive to the clone command above?
Collaborator
Author
There was a problem hiding this comment.
That recursively clones all the submodules of the submodules, which aren’t actually needed - we only need the top-level of the submodules, hence the separate steps. I don’t think this is an issue anymore for the submodules in SDK 2.0.0, but in SDK 1.5.1 tinyusb has a bunch of submodules that we don’t want to clone
There was a problem hiding this comment.
If you also add --depth 1 it reduces the overall clone size (top level and submodules).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add locations.md file, which has instructions to manually download the required tools, in case the extension is failing to download something