-
Notifications
You must be signed in to change notification settings - Fork 157
Support for RP2350 A2/A3/A4 along with code improvements #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kilograham
commented
Aug 6, 2025
- replaced the ocean of one-off IFs with a more OO abstraction
…he ocean of one-off IFs with a more OO abstraction
Contributor
|
|
lurch
reviewed
Aug 6, 2025
lurch
reviewed
Aug 6, 2025
lurch
reviewed
Aug 6, 2025
lurch
reviewed
Aug 6, 2025
Co-authored-by: Andrew Scheller <[email protected]>
will-v-pi
reviewed
Aug 7, 2025
will-v-pi
approved these changes
Aug 7, 2025
Contributor
will-v-pi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and all LGTM
kilograham
added a commit
that referenced
this pull request
Aug 7, 2025
* Support for RP2350 A2/A4/A4 along with code improvements, replacing the ocean of one-off IFs with a more OO abstraction Co-authored-by: William Vinnicombe <[email protected]> Co-authored-by: will-v-pi <[email protected]> Co-authored-by: Andrew Scheller <[email protected]> Co-authored-by: graham sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.