Skip to content

Enabling switch to non-deprecated version of function for G4.11.3 #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarcFBergevin
Copy link
Contributor

@MarcFBergevin MarcFBergevin commented May 19, 2025

Adding G4 flag to switch function depending on G4 version user has installed. Works with latest G4.11.3

There is currently a warning due to optics that needs to be resolved. If someone could test this works on version below 11.3 I would appreciate.

fixes #192

@MarcFBergevin
Copy link
Contributor Author

Warning message goes as follow:

-------- WWWW ------- G4Exception-START -------- WWWW -------
*** G4Exception : mat219
      issued by : G4MaterialPropertiesTable::AddProperty()
AddProperty warning. A material property vector must have more than one value.
Unless you will later add an entry, this is an error.
Property name: SCINTMOD
*** This is just a warning message. ***
-------- WWWW -------- G4Exception-END --------- WWWW -------

@JamesJieranShen
Copy link
Contributor

Hi Marc, this is reported in #192 . However, i'm not sure these methods should only be switched for g4 versions. These methods seem to exist sinces ages ago if i'm reading the source code correctly. Perhaps we should just do the switch for all builds.

Need to look closer for the MatTable issue though.

@MarcFBergevin
Copy link
Contributor Author

You have a point. Interesting that it did not create warning for me before I switched to Geant4.11.3. Need to search for what geant4 version I was using.

@JamesJieranShen
Copy link
Contributor

Default ratpac-setup uses 11.1, and I think warnings started issue for me circa 11.2

@MarcFBergevin
Copy link
Contributor Author

@tannerbk Was there any specific tests you wanted to do for that issue? Right now I just went with the proposed change, and it did seem to pass the reco rattest, but not sure if it affected processing time or any other part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated G4 calls in GLG4PMTOpticalModel
2 participants