Clean-up of geo files #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,8 +84,6 @@ G4VPhysicalVolume *DetectorConstruction::Construct() { | |||
|
|
|||
| // Add sensitive volumes here (only veto for now) | |||
| G4SDManager *sdman = G4SDManager::GetSDMpointer(); | |||
There was a problem hiding this comment.
CMake now complains that sdman : warning: unused variable 'sdman' [-Wunused-variable].
Any reason to keep the G4SDManager line?
There was a problem hiding this comment.
Removed this line and the code compiled without issue. Searched for this string and found that it was not called within DetectorConstruction.cc. While found in other functions, it looked like it was properly called within those functions.
Output of grep:
src/geo/src/GeoFactory.cc: G4SDManager *sdman = G4SDManager::GetSDMpointer();
src/geo/src/GeoFactory.cc: G4VSensitiveDetector *sd = sdman->FindSensitiveDetector(sensitive_detector);
src/geo/src/GeoNestedTubeConstruction.cc: G4SDManager *sdman = G4SDManager::GetSDMpointer();
src/geo/src/GeoNestedTubeConstruction.cc: sdman->AddNewDetector(sensitive);
src/geo/src/GeoSolidArrayFactoryBase.cc: G4SDManager *sdman = G4SDManager::GetSDMpointer();
src/geo/src/GeoSolidArrayFactoryBase.cc: G4VSensitiveDetector *sd = sdman->FindSensitiveDetector(sensitive_detector_name);
Please consider removing this line, and I think this is Good To Go from my perspective.
|
I may move these files to a legacy directory instead of deleting them entirely, so marking this as not ready to merge for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused or eos specific files.
fixes #267