Skip to content

Comments

Update coding standards to latest versions#75

Merged
koriym merged 2 commits into1.xfrom
feature/update-coding-standards
Nov 20, 2025
Merged

Update coding standards to latest versions#75
koriym merged 2 commits into1.xfrom
feature/update-coding-standards

Conversation

@koriym
Copy link
Member

@koriym koriym commented Nov 20, 2025

Summary

Updates development tools to their latest versions for better code quality and PHP 8.4 compatibility.

Changes

  • doctrine/coding-standard: ^13.0.1 → ^14.0
  • squizlabs/php_codesniffer: ^3.9 → ^4.0

Motivation

  • Stay current with latest coding standards
  • PHP_CodeSniffer 4.0 provides better PHP 8.4 support
  • Doctrine Coding Standard 14.0 includes latest best practices

Summary by Sourcery

Enhancements:

  • Bump doctrine/coding-standard to ^14.0 and squizlabs/php_codesniffer to ^4.0 for updated coding standards and PHP 8.4 compatibility

Summary by CodeRabbit

  • Chores
    • Updated internal development tools to newer versions, enhancing code quality and standards compliance processes.

✏️ Tip: You can customize this high-level summary in your review settings.

- doctrine/coding-standard: ^13.0.1 -> ^14.0
- squizlabs/php_codesniffer: ^3.9 -> ^4.0

All quality checks pass:
- Coding standards: ✓
- Static analysis: ✓
- Tests: ✓ (83 tests, 124 assertions)
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates dev tooling by bumping doctrine/coding-standard to ^14.0 and squizlabs/php_codesniffer to ^4.0, adjusting composer.json and regenerating composer.lock with all quality checks passing.

File-Level Changes

Change Details Files
Upgrade coding standard tools to latest major versions
  • Bump doctrine/coding-standard from ^13.0.1 to ^14.0
  • Bump squizlabs/php_codesniffer from ^3.9 to ^4.0
  • Run composer update to regenerate composer.lock
vendor-bin/tools/composer.json
vendor-bin/tools/composer.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Warning

Rate limit exceeded

@koriym has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 55ad3f7 and 827b67f.

📒 Files selected for processing (1)
  • phpcs.xml (1 hunks)

Walkthrough

Updates two devDependencies in the tools composer configuration: doctrine/coding-standard from ^13.0.1 to ^14.0 and squizlabs/php_codesniffer from ^3.9 to ^4.0. No other configuration or requirement changes.

Changes

Cohort / File(s) Change Summary
Dependency version updates
vendor-bin/tools/composer.json
Updated doctrine/coding-standard to ^14.0 (major version bump from ^13.0.1) and squizlabs/php_codesniffer to ^4.0 (major version bump from ^3.9)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify compatibility of major version bumps for doctrine/coding-standard and squizlabs/php_codesniffer with the existing codebase
  • Confirm that no deprecated APIs or breaking changes in these libraries affect the project's code standards configuration

Poem

🐰 Dependency dreams take flight so high,
From thirteen to fourteen, we reach for the sky!
PHP sniffers sharpen their keen-eyed sight,
Version four brings standards into the light! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating development dependencies (coding-standard and PHP_CodeSniffer) to their latest versions, which is the sole focus of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Align PHP version check with composer.json requirement (^8.2)

- Changed php_version from 80100 (8.1) to 80200 (8.2)
- All coding standards checks pass
@koriym koriym merged commit 9d6d706 into 1.x Nov 20, 2025
27 checks passed
@koriym koriym deleted the feature/update-coding-standards branch November 20, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant