Skip to content

Commit

Permalink
chore: add rayCluseter Namespace and Name to logger and return nil to…
Browse files Browse the repository at this point in the history
… avoid rescheduling in `validateRayClusterSpec`
  • Loading branch information
CheyuWu committed Jan 13, 2025
1 parent 31b75f6 commit 987dbb2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ray-operator/controllers/ray/raycluster_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,10 @@ func (r *RayClusterReconciler) rayClusterReconcile(ctx context.Context, instance
}

if err := validateRayClusterSpec(instance); err != nil {
logger.Error(err, "The RayCluster spec is invalid")
logger.Error(err, fmt.Sprintf("The RayCluster spec is invalid %s/%s", instance.Namespace, instance.Name))
r.Recorder.Eventf(instance, corev1.EventTypeWarning, string(utils.InvalidRayClusterSpec),
"The RayCluster spec is invalid %s/%s: %v", instance.Namespace, instance.Name, err)
return ctrl.Result{}, err
return ctrl.Result{}, nil
}

if err := r.validateRayClusterStatus(instance); err != nil {
Expand Down

0 comments on commit 987dbb2

Please sign in to comment.