Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding just the args in submitter pod #2208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow overriding just the args in submitter pod #2208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ray-operator/controllers/ray/rayjob_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,8 @@ func (r *RayJobReconciler) getSubmitterTemplate(ctx context.Context, rayJobInsta
logger.Info("user-provided submitter template is used; the first container is assumed to be the submitter")
}

// If the command in the submitter pod template isn't set, use the default command.
if len(submitterTemplate.Spec.Containers[utils.RayContainerIndex].Command) == 0 {
// If neither the command nor the args are set in the submitter pod template, use the default command.
if len(submitterTemplate.Spec.Containers[utils.RayContainerIndex].Command) == 0 && len(submitterTemplate.Spec.Containers[utils.RayContainerIndex].Args) == 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test for this case?

k8sJobCommand, err := common.GetK8sJobCommand(rayJobInstance)
if err != nil {
return corev1.PodTemplateSpec{}, err
Expand Down
Loading