some logs are not json format #2535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fscnick <[email protected]>
Signed-off-by: fscnick <[email protected]>
|
@kevin85421 PTAL |
fscnick
changed the title
kevin85421
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Could you add a screenshot? CC @MortalHappiness: Could you shepherd this PR? I’m currently at KubeCon.
Thanks for the feedback. Here it is. |
| k8sLogger := k8szap.New(k8szap.UseFlagOptions(&opts)) | ||
| ctrl.SetLogger(k8sLogger) | ||
| klog.SetLogger(k8sLogger) | ||
|
|
|
@fscnick From your screenshot, it seems that the logger information is lost. Can you try to also log the logger? I mean before the log is set to json format, we know that this log is from If it's technically infeasible, feel free to leave another comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some logs from client-go are not in JSON format.
According to kubernetes/client-go#18 (comment),
Calling
klog.SetLogger()applies logs with JSON format from client-go.Related issue number
Closes #2512
Checks