[RayCluster][Fix] DesiredReplicas, MinReplicas and MaxReplicas should respect workerGroupSpec.Suspend #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… respect workerGroupSpec.Suspend
rueian
force-pushed
the
fix-cluster-desire-with-suspended-groups
branch
from
374ab4f to
c8f8263
Compare
|
Hi @kevin85421, @MortalHappiness please take a look. PS. The failing check seems unrelated to this change. |
kevin85421
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
While working on #2666, I found that the
DesiredWorkerReplicasin the RayCluster status remains incorrect when some worker groups have been suspended. Suspended worker groups should not be counted in theDesiredWorkerReplicas, or it will confuse users. TheMinWorkerReplicasandMaxWorkerReplicasstatuses are in the same situation.Related issue number
Checks