[RayCluster] Validate RayClusterSpec for empty containers and GCS FT #2749
+131
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
kevin85421
changed the title
|
cc @rueian would you mind reviewing this PR? |
|
also cc @CheyuWu since this is the follow up of your PR. |
dentiny
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ensure PodSpec has at least one container: OpenAPI only validates whether
containersexists in the PodSpec or not. However, it doesn't validate whether the PodSpec has at least one container or not. In K8s, it is validated in the server side: https://sourcegraph.com/github.com/kubernetes/kubernetes/-/blob/pkg/apis/core/validation/validation.go?L3635. In KubeRay, we assume that the Ray container is the first container in the Pod. To avoid segfault in KubeRay, this PR checks whether all PodSpec have at least one container or not.GcsFaultToleranceOptionsand the annotation should not be set at the same time.RAY_REDIS_ADDRESSshould not be set if KubeRay doesn't aware of GCS FT is enabled.Update error messages to encourage users to use new API
GcsFaultToleranceOptions.Related issue number
Follow up #2726
Checks