Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayJob] RayJob deletion policy validation #2771

Merged

Conversation

rueian
Copy link
Contributor

@rueian rueian commented Jan 17, 2025

Why are these changes needed?

This is a follow-up RP for #2748, adding the following validation on RayJob:

  1. DeletionPolicy can only be used when the RayJobDeletionPolicy feature gate is enabled.
  2. DeletionPolicy=DeleteCluster can't be used with ClusterSelector.
  3. DeletionPolicy=DeleteWorkers can't be used with ClusterSelector.
  4. DeletionPolicy=DeleteWorkers currently can't be used with Autoscaler.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@rueian rueian marked this pull request as ready for review January 17, 2025 23:49
@rueian
Copy link
Contributor Author

rueian commented Jan 18, 2025

Hi @kevin85421 and @andrewsykim, this is ready and please take a look.

@kevin85421 kevin85421 merged commit f191a75 into ray-project:master Jan 19, 2025
23 of 24 checks passed
win5923 pushed a commit to win5923/kuberay that referenced this pull request Jan 20, 2025
win5923 pushed a commit to win5923/kuberay that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants