[kubectl-plugin] Generate submission_id in job_submit.go
#3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@MortalHappiness PTAL |
MortalHappiness
approved these changes
May 27, 2025
Signed-off-by: LeoLiao123 <[email protected]>
Signed-off-by: LeoLiao123 <[email protected]>
LeoLiao123
force-pushed
the
feature/gen-submission-id-in-kuberay
branch
from
f82df39 to
69763fe
Compare
kevin85421
approved these changes
May 27, 2025
pawelpaszki
pushed a commit
to opendatahub-io/kuberay
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #3624.
This solution generates the
submission_idinrayjob_submit.goand passes it via the CLI’s--submission-idflag, avoiding the unstable assumption that the CR contains only onesubmission_idand then usinglist_jobto retrieve the first one.Related issue number
Closes #3624
Also fix #3675
Checks