Skip to content

[Test][Autoscaler] deflaky unexpected dead actors in tests by setting max_restarts=-1 #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

[Test][Autoscaler] deflaky unexpected dead actors in tests by setting max_restarts=-1 #3700

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89cdda8
[Test][Autoscaler] deflaky unexpected dead actors in tests by setting…
rueian May 27, 2025
615e570
Merge branch 'master' into e2eautoscaler-deflaky-dead-actor
rueian Jun 4, 2025
6322758
[Test][Autoscaler] deflaky unexpected dead actors in tests by setting…
rueian Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ray-operator/test/e2eautoscaler/create_detached_actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
parser.add_argument('--num-custom-resources', type=float, default=0)
args = parser.parse_args()

@ray.remote(num_cpus=args.num_cpus, num_gpus=args.num_gpus, resources={"CustomResource": args.num_custom_resources})
# set max_restarts=-1 as a workaround to restart unexpected death in tests.
# TODO (rueian): Remove the max_restarts workaround when https://github.com/ray-project/ray/issues/40864 is fixed.
@ray.remote(max_restarts=-1, num_cpus=args.num_cpus, num_gpus=args.num_gpus, resources={"CustomResource": args.num_custom_resources})
class Actor:
pass

Expand Down
Loading