[RayService][Test] create curl pod waiting until running #3740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscnick
commented
Jun 3, 2025
Comment on lines
+54
to
+73
| func IsPodRunningAndReady(pod *v1.Pod) bool { | ||
| if pod.Status.Phase != v1.PodRunning { | ||
| return false | ||
| } | ||
| for _, condition := range pod.Status.Conditions { | ||
| if condition.Type == v1.PodReady && condition.Status == v1.ConditionTrue { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| func AllPodsRunningAndReady(pods []v1.Pod) bool { | ||
| for _, pod := range pods { | ||
| if !IsPodRunningAndReady(&pod) { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
Move these two support functions from sampleyaml/support.go to here because of cyclic imports.
fscnick
force-pushed
the
create-curl-pod-wait-until-running
branch
from
25d4fa9 to
7004d56
Compare
Signed-off-by: fscnick <[email protected]>
fscnick
force-pushed
the
create-curl-pod-wait-until-running
branch
from
7004d56 to
1df9cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
CreateCurlPodneed to wait for pod is ready and running. put the waiting logic inside the function for easier to use.Related issue number
Close #3613
Checks