[kubeclt-plugin] fix get cluster all namespace #3809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fscnick <[email protected]>
fscnick
commented
Jun 19, 2025
| } | ||
| if tc.namespace != nil { | ||
| fakeClusterGetOptions.namespace = *tc.namespace | ||
| } | ||
|
|
||
| kubeClientSet := kubefake.NewClientset() | ||
| rayClient := rayClientFake.NewSimpleClientset(tc.rayClusters...) | ||
| rayClient := rayClientFake.NewSimpleClientset(tc.injectedRayClusters...) |
There was a problem hiding this comment.
The original code takes tc.rayClusters to inject to fake client and tc.rayClusters also be a condition to verify the result. That seems put what you expected and verify it. It might lack the capability of testing exclusion. Thus, add tc.injectedRayClusters to provide this possibility.
fscnick
commented
Jun 19, 2025
| @@ -42,7 +42,7 @@ func TestRayClusterGetComplete(t *testing.T) { | |||
| name: "neither namespace nor args set", | |||
| namespace: "", | |||
| args: []string{}, | |||
| expectedAllNamespaces: true, | |||
| expectedAllNamespaces: false, | |||
There was a problem hiding this comment.
The original test case looks like the all namespace is expected if no namespace provide. However, it is not consistent with get nodes and get workergroup
|
@MortalHappiness PTAL |
| expectedOutput string | ||
| cluster string | ||
| expectedRayClusters []runtime.Object | ||
| injectedRayClusters []runtime.Object |
There was a problem hiding this comment.
Suggested change
| injectedRayClusters []runtime.Object | |
| allFakeRayClusters []runtime.Object |
Signed-off-by: fscnick <[email protected]>
MortalHappiness
approved these changes
Jun 20, 2025
kevin85421
approved these changes
Jun 20, 2025
MortalHappiness
pushed a commit
to MortalHappiness/kuberay
that referenced
this pull request
Jun 20, 2025
Signed-off-by: fscnick <[email protected]>
MortalHappiness
added a commit
that referenced
this pull request
Jun 20, 2025
Signed-off-by: fscnick <[email protected]> Co-authored-by: fscnick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Either
--all-namespacesis true or false onkubectl ray get cluster, it shows RayClusters in all namespaces. This pr changes the behavior to search the default namespace if--all-namespacesis false.However, the original behavior seems intentionally. There are some test cases to ensure this behavior. But the original behavior isn't consistent with
get nodeandget workergroup. Additionally, it doesn't align the convention likekubectl get powhich only retrieves the resources from the default namespace instead of all namespaces. Kind correct me if the original behavior is expected.Related issue number
Closes #3806
Checks