Skip to content

[kubectl-plugin] Remove ephemeral storage check #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Jun 21, 2025

Why are these changes needed?

I think the util.ValidateResourceQuantity already handles empty string values, so we can remove this.

func ValidateResourceQuantity(value string, name string) error {
if value == "" {
return nil
}

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@win5923 win5923 marked this pull request as ready for review June 21, 2025 09:01
@win5923 win5923 changed the title [kubectl-plugin] Remove Remove redundant ephemeral storage validation [kubectl-plugin] Remove redundant ephemeral storage validation Jun 21, 2025
@win5923 win5923 changed the title [kubectl-plugin] Remove redundant ephemeral storage validation [kubectl-plugin] Remove ephemeral storage validation Jun 22, 2025
@win5923 win5923 changed the title [kubectl-plugin] Remove ephemeral storage validation [kubectl-plugin] Remove ephemeral storage check Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant