[Feature] Support inject specific env vars to all Ray containers in all RayCluster CRs by ConfigMap #4103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win5923
force-pushed
the
inject-specific-env-in-ray
branch
from
bb9068f to
238677a
Compare
…uster CRs Signed-off-by: win5923 <[email protected]>
win5923
force-pushed
the
inject-specific-env-in-ray
branch
from
238677a to
39c4813
Compare
win5923
changed the title
win5923
force-pushed
the
inject-specific-env-in-ray
branch
3 times, most recently
from
442f118 to
77048d8
Compare
win5923
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
|
Hi @kevin85421, PTAL when you have time, thanks! |
win5923
force-pushed
the
inject-specific-env-in-ray
branch
from
77048d8 to
bacdedd
Compare
Signed-off-by: win5923 <[email protected]>
win5923
force-pushed
the
inject-specific-env-in-ray
branch
from
bacdedd to
3bfb280
Compare
win5923
changed the title
rueian
reviewed
Oct 3, 2025
| @@ -0,0 +1,15 @@ | |||
| {{- if .Values.defaultRayEnvs }} | |||
There was a problem hiding this comment.
This check could be a problem if we want to add more fields to the configuration in the future. Is it possible that we always generate the configmap?
There was a problem hiding this comment.
Nice suggestion! I've updated to use configuration.enabled to control whether the ConfigMap should be created.
55852fd
|
also cc @andrewsykim for review because you implemented the config API. |
Signed-off-by: win5923 <[email protected]>
win5923
force-pushed
the
inject-specific-env-in-ray
branch
from
070b4f7 to
55852fd
Compare
rueian
reviewed
Oct 11, 2025
| | batchScheduler.enabled | bool | `false` | | | ||
| | batchScheduler.name | string | `""` | | | ||
| | configuration.enabled | bool | `false` | Whether to enable the configuration feature. If enabled, a ConfigMap will be created and mounted to the operator. | | ||
| | configuration.defaultRayEnvs | list | `[]` | Default environment variables to inject into all Ray containers in all RayCluster CRs. This allows user to set feature flags across all Ray pods. Example: defaultRayEnvs: - name: RAY_enable_open_telemetry value: "true" - name: RAY_metric_cardinality_level value: "recommended" | |
There was a problem hiding this comment.
I feel like RayEnvs is a bit confusing. The envs themselves can be unrelated to Ray. Maybe defaultContainerEnvs is better?
There was a problem hiding this comment.
Change to defaultContainerEnvs. Thanks! 8cf8ba3
Signed-off-by: win5923 <[email protected]>
rueian
approved these changes
Oct 12, 2025
Future-Outlier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Added defaultRayEnvs field to the Configuration API, allowing user to inject environment variables into all Ray containers across all RayCluster CRs.
Also update kuberay-operator helm chart, now generates a
ConfigMapwith the Configuration YAML and mounts it to the operator whendefaultRayEnvsis set invalues.yaml.E2E
ray:2.49.0head pod:
worker pod:
The
WorkerIdtag has been removed for metrics such as ray_tasks.Related issue number
Closes #4098
Checks