[FEAT] show event message when raycluster not found in clusterSelector in rayjob #4125
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machichima
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
machichima
commented
Oct 11, 2025
| logger.Info("RayCluster not found", "RayCluster", rayClusterNamespacedName) | ||
| if len(rayJobInstance.Spec.ClusterSelector) != 0 { | ||
| err := fmt.Errorf("we have choosed the cluster selector mode, failed to find the cluster named %v, err: %w", rayClusterNamespacedName.Name, err) | ||
| err := fmt.Errorf("clusterSelector mode enabled, but RayCluster %s/%s not found: %w", rayClusterNamespacedName.Namespace, rayClusterNamespacedName.Name, err) |
There was a problem hiding this comment.
Rephrase the error message a bit
rueian
reviewed
Oct 11, 2025
rueian
reviewed
Oct 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR improves the debugging experience for RayJob users by adding an event message when a RayCluster specified in the clusterSelector is not found.
- Added a new event type
RayClusterNotFoundto provide better user feedback - Enhanced error message formatting to include namespace/name format consistently
- Emits a warning event when the specified RayCluster cannot be found in clusterSelector mode
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ray-operator/controllers/ray/utils/constant.go | Adds new RayClusterNotFound event type constant |
| ray-operator/controllers/ray/rayjob_controller.go | Improves error message and adds event emission for missing RayCluster |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Rueian <[email protected]>
rueian
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When we set RayCluster in the rayjob's cluster selector, if the raycluster not found, the rayjob will stuck in initialize without any event message, it is hard to debug without digging into the ray-operator logs.
We send an event when the raycluster set in the clusterSelector is not found, guiding user to create the raycluster manually
Tested locally:
Related issue number
Checks