[core][compiled graphs] Check for unused input attributes #49382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lydia <[email protected]>
Signed-off-by: Lydia <[email protected]>
Signed-off-by: Lydia <[email protected]>
Signed-off-by: Lydia <[email protected]>
Signed-off-by: Lydia <[email protected]>
ruisearch42
reviewed
Dec 31, 2024
Signed-off-by: Stephanie wang <[email protected]>
stephanie-wang
changed the title
Signed-off-by: Stephanie wang <[email protected]>
stephanie-wang
approved these changes
Jan 21, 2025
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Jan 23, 2025
…t#49382) If a user forgets to use a DAG's input attributes, it can lead to silent errors. This PR adds a check to make sure that there is a path between all DAG input attributes and the DAG's final output. ## Related issue number Closes ray-project#47165 --------- Signed-off-by: Lydia <[email protected]> Signed-off-by: Stephanie wang <[email protected]> Co-authored-by: Stephanie wang <[email protected]>
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
If a user forgets to use a DAG's input attributes, it can lead to silent errors. This PR adds a check to make sure that there is a path between all DAG input attributes and the DAG's final output. ## Related issue number Closes #47165 --------- Signed-off-by: Lydia <[email protected]> Signed-off-by: Stephanie wang <[email protected]> Co-authored-by: Stephanie wang <[email protected]>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
…t#49382) If a user forgets to use a DAG's input attributes, it can lead to silent errors. This PR adds a check to make sure that there is a path between all DAG input attributes and the DAG's final output. ## Related issue number Closes ray-project#47165 --------- Signed-off-by: Lydia <[email protected]> Signed-off-by: Stephanie wang <[email protected]> Co-authored-by: Stephanie wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If a user forgets to use a DAG's input attributes, it can lead to silent errors. This PR adds a check to make sure that there is a path between all DAG input attributes and the DAG's final output.
Related issue number
Closes #47165
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.