[core] (cgroups 16/n) Changing the algorithm for default values for system reserved resources #57653
+380
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CgroupManagerFactory which constructs a cross-platform cgroup manager with selective compilation Signed-off-by: irabbani <[email protected]>
and CgroupManagerFactory are the only public targets. CgroupManagerFactory will delegate to the appropriate implementation for each platform. Signed-off-by: irabbani <[email protected]>
build. The Cgroup subsystem only exposes CgroupManagerInterface and CgroupManagerFactory as public targets. Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
… irabbani/cgroups-14 Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
… irabbani/cgroups-14 Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: israbbani <[email protected]>
subtrees: - the system cgroup has all ray system processes. - the workers cgroup has all ray worker processes. - the user cgroup has all other non-ray processes on the system (usually used with containers). Updated the integration tests. Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
… irabbani/cgroups-14 Signed-off-by: irabbani <[email protected]>
Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: Ibrahim Rabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: israbbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: Ibrahim Rabbani <[email protected]>
… irabbani/cgroups-15 Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
now be between [1,3] cpu cores (converted to weights) and [0.5G, 10G] bytes of memory. Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
… irabbani/cgroups-16 Signed-off-by: irabbani <[email protected]>
values for system-reserved-cpu and system-reserved-memory such that the the values are - always greater than a minimum value (1 cpu, 0.5GB of memory) - scale proportionately with system resources if gte minimum (5% of cpu, 10% of memory) - cap out at a maximum value (3 cpus, 10G of memory) Rewrote the unit tests to test this logic. Signed-off-by: irabbani <[email protected]>
israbbani
added
core
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: irabbani <[email protected]>
… irabbani/cgroups-16 Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
edoakes
approved these changes
Oct 13, 2025
|
@israbbani I merged upstream and re-triggered CI after merging the other one; ping to merge if tests pass here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stacks on #57269 .
For more details about the resource isolation project see #54703.
In this PR, I've revised the algorithm for choosing default values for
system-reserved-cpuandsystem-reserved-memory. The intent behind the algorithm is to:DEFAULT_SYSTEM_RESERVED_{MEMORY|CPU_CORES}_PROPORTIONDEFAULT_MIN_SYSTEM_RESERVED_{CPU_CORES|MEMORY}, use the constant.DEFAULT_MAX_SYSTEM_RESERVED_{CPU_CORES|MEMORY}, use the constant.This has a few useful properties