[release test] make more files a standalone py_library's #57661
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes good progress on breaking down the ray_release package into smaller, more manageable Bazel py_library targets. The changes correctly identify several modules that can be standalone and update the build definitions and test dependencies accordingly.
My main feedback is regarding a circular dependency between result.py and exception.py. While the current changes might work due to a local import, it's not ideal for a clean modular architecture. I've suggested a refactoring to break this cycle for better long-term maintainability. Addressing this will make the modularization effort even more effective.
aslonnie
force-pushed
the
lonnie-251012-winfix4
branch
from
f0780fd to
400c67f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aslonnie
force-pushed
the
lonnie-251012-winfix4
branch
2 times, most recently
from
13e41fe to
07e792e
Compare
working towards breaking down `ray_release package` into smaller modules moves ExitCode to exception.py Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
force-pushed
the
lonnie-251012-winfix4
branch
from
07e792e to
fa2823e
Compare
1 participant
working towards breaking down
ray_release packageinto smaller modules