remove async capability enum #57666
remove async capability enum #57666
Conversation
harshit-anyscale
commented
Oct 13, 2025
harshit-anyscale
commented
- removing enum capability enum as it is not being used, for more details: add celery default serializer and add new fields in celery adapter config #56707 (comment)
Signed-off-by: harshit <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the unused AsyncCapability enum and its related logic from TaskProcessorAdapter, which simplifies the code. The changes are focused and look good. I've added one comment to improve the clarity of the __init__ method's docstring. As a follow-up, you might also want to update the class docstring for TaskProcessorAdapter in python/ray/serve/schema.py which still refers to the removed supports_async_capability method, and remove a stale comment in CeleryTaskProcessorAdapter.__init__ in python/ray/serve/task_processor.py that refers to the removed _async_capabilities attribute.
| """ | ||
| Initialize the TaskProcessorAdapter. | ||
| Sets up an empty set of async capabilities. Subclasses should add their | ||
| supported async capabilities to self._async_capabilities in their __init__ | ||
| method. | ||
| """ | ||
| self._async_capabilities: Set[AsyncCapability] = set() | ||
|
|
||
| @property | ||
| def async_capabilities(self) -> Set[AsyncCapability]: | ||
| """ | ||
| Get the set of async capabilities supported by this adapter. | ||
| Returns: | ||
| Set[AsyncCapability]: A copy of the set containing all async capabilities | ||
| supported by this adapter. Modifying the returned set will not affect | ||
| the adapter's capabilities. | ||
| """ | ||
| return self._async_capabilities.copy() | ||
|
|
||
| def supports_async_capability(self, capability: AsyncCapability) -> bool: | ||
| """ |
There was a problem hiding this comment.
The docstring for __init__ can be simplified to a single line since it's just a summary now. The current formatting with extra blank lines can be confusing.
"""Initialize the TaskProcessorAdapter."""Signed-off-by: harshit <[email protected]>
2 participants
