Skip to content

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Oct 13, 2025

Why are these changes needed?

Cleaning out plasma and the plasma client and its neighbors.

The plasma client had a pimpl implementation, even though we didn't really need anything that would come with pimpl out of plasma. So just killing the separate impl class and just having the plasma client and its interface. One note about this is that it needs shared_from_this and the old plasma client would always contain a shared ptr to the impl, so had to refactor the raylet to use a shared ptr to the plasma client so we could keep using the shared_from_this.

Other cleanup:

  • a lot of the ipc functions always returned status::ok so changed to void
  • some extra reserving of vectors and moving
  • unnecessary consts in pull manager that would prevent moves
    etc.

@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Oct 13, 2025
Signed-off-by: dayshah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant