[rmodels] Ensure that GLTF buffers are deallocated before using them#4998
Closed
JeffM2501 wants to merge 1 commit intoraysan5:masterfrom
Closed
[rmodels] Ensure that GLTF buffers are deallocated before using them#4998JeffM2501 wants to merge 1 commit intoraysan5:masterfrom
JeffM2501 wants to merge 1 commit intoraysan5:masterfrom
Conversation
…we don't leak that buffer in cases where the gltf may have duplicate attributes at different resolutions. Should fix issue raysan5#4996
Owner
|
I'm afraid I'm not adding all those checks, two reasons:
|
Contributor
Author
|
we will have to make a different check then. This is a legitimate memory leak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check to see if a mesh buffer is allocated before reallocating it so we don't leak that buffer in cases where the gltf may have duplicate attributes at different resolutions.
Should fix issue #4996