-
Notifications
You must be signed in to change notification settings - Fork 36
feat: migrate Organization Admin RPCs to connectRPC server #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates Organization Admin RPCs to use the connectRPC server framework, adding new admin endpoints for organization management and enabling gRPC reflection for better tooling support.
- Adds gRPC reflection support with handlers for both v1 and v1alpha reflection APIs
- Implements new organization admin endpoints:
ListAllOrganizations
andAdminCreateOrganization
- Introduces metadata schema validation for organization creation with proper error handling
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
pkg/server/server.go | Adds gRPC reflection handlers for service discovery |
internal/api/v1beta1connect/organization.go | Implements new admin organization endpoints with filtering and validation |
internal/api/v1beta1connect/errors.go | Adds metadata validation error definitions |
go.mod | Adds grpcreflect dependency for reflection support |
Comments suppressed due to low confidence (1)
internal/api/v1beta1connect/organization.go:57
- The variable name 'v' is not descriptive. Consider renaming it to 'org' or 'organization' to improve code readability.
for _, v := range orgList {
Pull Request Test Coverage Report for Build 16440758135Details
💛 - Coveralls |
Migrate Organization AdminRPC to ConnectRPC server
The following RPCs are migrated.
The implementation of the handlers is similar to that of the gRPC handlers. I have just made it compatible with ConnectRPC signature. We have used connect errors instead of gRPC errors.
We have also added Server Reflections to support development with tools like Postman.