ddl2cpp: Cleanup part 3 #76
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third PR that cleans up the ddl2cpp code. It provides the following changes:
There we several problems with this:
Also the message did not make a difference between an SQL data type and an sqlpp23 data type and in fact these are different data types, an SQL data type is just a keyword, recognized by the database, e.g.
INT
, while the sqlpp23 data type is a C++ structure, e.g.sqlpp23::integral
. So I tried to differentiate these two terms to make it clear that both should be implemented.In the end the proposed error message looks like:
I tested the PR creating a single header, split headers and a module, each of these with table creation helpers (
--generate-table-creation-helper
) and it seems to work correctly. Also tested DDL definitions with custom types and--path-to-datatype-file
and this worked correctly too.