Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core/WebSocketLink] : Enable unsollicited 'Pong' and rename enum item #1784

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

msieben
Copy link
Contributor

@msieben msieben commented Oct 25, 2024

  • Rename 'WEBSERVER' to 'WEBSERVICE' as both client and server utilize state information

  • Unsollicited 'Pong' may act as a heart beat

@pwielders
Copy link
Contributor

@msieben the enum is a public interface. You can not change it in one go. Support both, deprecate the old one and in a next Major Release we can drop it. This should not go in 1 go. Code might depend on this enum value.
Please also refer to a ticket this is solving..

Copy link
Contributor

@pwielders pwielders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep on supporting the "old enum" value, add the new enum value and use the DEPRECATE keyword on the old enum value so code will raise a warning that the enum needs to be changed. In the next Major Release we can drop it than.

…m item

- Rename 'WEBSERVER' to 'WEBSERVICE' as both client and server utilize state information

- Unsollicited 'Pong' may act as a heart beat
@msieben msieben merged commit 5712a36 into master Nov 7, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants