[json]: Improve Handling of Empty JSON Arrays in JSON::ArrayType #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. (rdkcentral#1112) Using the new method Set on the JSON::ArrayType<> template, the array can be set to Serialize although there are no elements available in the array. The Serialization will show like: "fieldName": [] This can be used to indicate that a field has been set but there is no data for this field.
…tral#1448) In the context of the JSON::ArrayType type, a previous change was added for the serialization of empty array ie: to differentiate between a set but empty and a null JSON array container. The resulting implementation, however, failed to deserialize properly, because when finding a empty JSON array (i.e. `someArray: []`), the resulting object would be equivalent to `someArray: null`, which is incorrect. To fix this, this commit adds the setting of the `_state` data member in the `Deserialize` method when a matching pair of square brackets are correctly parsed.
|
I guess this is a backport from R4 to R2. For me good to go.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines JSON::ArrayType to ensure consistent handling of empty JSON arrays during both serialization and deserialization. The first enhancement introduces a Set method to serialize an empty array as "fieldName": [], indicating that a field is explicitly set, even if it contains no data. Additionally, this PR addresses an issue in deserialization where an empty array (someArray: []) was previously interpreted as null. With the new changes, the deserialization process now correctly identifies and preserves empty arrays, maintaining a clear distinction from null values. These improvements standardize empty array handling in JSON::ArrayType