Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Portability] The stringop-overread warning is not available on clang #1789

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

VeithMetro
Copy link
Contributor

@VeithMetro VeithMetro commented Nov 12, 2024

It came up while building one of the plugins on macOS (Apple Clang) which uses this macro to disable a warning:

[1/105] Building CXX object DHCPServer/CMakeFiles/ThunderDHCPServer.dir/DHCPServer.cpp.o
FAILED: DHCPServer/CMakeFiles/ThunderDHCPServer.dir/DHCPServer.cpp.o 
/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPROCESSCONTAINERS_ENABLED=1 -DTHUNDER_PLATFORM_PC_UNIX=1 -DThunderDHCPServer_EXPORTS -DWARNING_REPORTING_ENABLED -D_TRACE_LEVEL=0 -D__CORE_MESSAGING__ -D__CORE_NO_WCHAR_SUPPORT__ -D__CORE_WARNING_REPORTING__ -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/MinSizeRel/install/usr/include/Thunder -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/MinSizeRel/install/usr/include -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/MinSizeRel/install/usr/include/Thunder/processcontainers -Wall -Wextra -Wpedantic -Werror -Os -DNDEBUG -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT DHCPServer/CMakeFiles/ThunderDHCPServer.dir/DHCPServer.cpp.o -MF DHCPServer/CMakeFiles/ThunderDHCPServer.dir/DHCPServer.cpp.o.d -o DHCPServer/CMakeFiles/ThunderDHCPServer.dir/DHCPServer.cpp.o -c /Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/DHCPServer/DHCPServer.cpp
In file included from /Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/DHCPServer/DHCPServer.cpp:20:
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/DHCPServer/DHCPServer.h:88:17: error: unknown warning group '-Wstringop-overread', ignored [-Werror,-Wunknown-warning-option]
                        PUSH_WARNING(DISABLE_WARNING_STRING_OPERATION_OVERREAD);
                                     ^

@VeithMetro VeithMetro merged commit d16cdd1 into master Nov 12, 2024
63 checks passed
@VeithMetro VeithMetro deleted the development/stringop-overread-clang branch November 12, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants