DELIA-62843:TTS thunder plugin missing "speechrate" attribute#272
Merged
pwielders merged 2 commits intordkcentral:masterfrom Aug 8, 2023
vdinak240:master
Merged
DELIA-62843:TTS thunder plugin missing "speechrate" attribute#272pwielders merged 2 commits intordkcentral:masterfrom vdinak240:master
pwielders merged 2 commits intordkcentral:masterfrom
vdinak240:master
Conversation
Reason for change: TTS thunder plugin missing "speechrate" Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]>
pwielders
approved these changes
Aug 8, 2023
Contributor
pwielders
left a comment
pwielders
left a comment
There was a problem hiding this comment.
This is a breaking interface change and for Metro development not allowed (Metro within major releases is bound to be backwards compatible). Since this interface is only implemented by Comcast I assume you know what you are doing ;-) Do approved it with this warning...
cmurug728
pushed a commit
to cmurug728/ThunderInterfaces
that referenced
this pull request
Sep 14, 2023
…tral#272) Reason for change: TTS thunder plugin missing "speechrate" Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]> Co-authored-by: Pierre Wielders <[email protected]>
cmurug728
pushed a commit
to cmurug728/ThunderInterfaces
that referenced
this pull request
Sep 14, 2023
…tral#272) Reason for change: TTS thunder plugin missing "speechrate" Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]> Co-authored-by: Pierre Wielders <[email protected]>
karuna2git
pushed a commit
that referenced
this pull request
Sep 14, 2023
…290) Reason for change: TTS thunder plugin missing "speechrate" Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]> Co-authored-by: Vishnu Dinakaran <[email protected]> Co-authored-by: Pierre Wielders <[email protected]>
pwielders
added a commit
that referenced
this pull request
Sep 21, 2023
…291) Reason for change: TTS thunder plugin missing "speechrate" Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]> Co-authored-by: Vishnu Dinakaran <[email protected]> Co-authored-by: Pierre Wielders <[email protected]>
volkan-aslan
pushed a commit
that referenced
this pull request
Nov 1, 2023
Reason for change: TTS thunder plugin missing "speechrate" Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]> Co-authored-by: Pierre Wielders <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: TTS thunder plugin missing "speechrate"
Test Procedure: Mentioned in ticket
Risks: Low