Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Adding a MacOS build workflow and making sure it is warning-free #395

Merged
merged 16 commits into from
Nov 12, 2024
Merged

[Actions] Adding a MacOS build workflow and making sure it is warning-free #395

merged 16 commits into from
Nov 12, 2024

Commits on Nov 4, 2024

  1. Add a macOS build template

    @VeithMetro
    VeithMetro authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c6e413a View commit details
    Browse the repository at this point in the history

  2. Create the build workflow

    @VeithMetro
    VeithMetro authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    97617b0 View commit details
    Browse the repository at this point in the history

  3. For now let's call the workflow on each push

    @VeithMetro
    VeithMetro authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    fade94c View commit details
    Browse the repository at this point in the history

  4. Make sure to build on this branch on calls from different repos

    @VeithMetro
    VeithMetro authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e40ff8b View commit details
    Browse the repository at this point in the history

  5. No need for the venv and jsonref here

    @VeithMetro
    VeithMetro authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3a32b16 View commit details
    Browse the repository at this point in the history

  6. Remove the architecture specification in the cmake build command

    @VeithMetro
    VeithMetro authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4990abc View commit details
    Browse the repository at this point in the history

  7. Correct the venv path

    @VeithMetro
    VeithMetro authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    451dd17 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. For now let's disable the shift-count-overflow warning 

    In file included from /Users/runner/work/ThunderInterfaces/ThunderInterfaces/ThunderInterfaces/interfaces/IDRM.h:49:
/Users/runner/work/ThunderInterfaces/ThunderInterfaces/ThunderInterfaces/interfaces/../interfaces/DRMHelper.h:54:21: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
                tmp <<= 8;
                    ^   ~
/Users/runner/work/ThunderInterfaces/ThunderInterfaces/ThunderInterfaces/interfaces/../interfaces/DRMHelper.h:81:68: note: in instantiation of function template specialization 'BufferReader::Read<unsigned char>' requested here
    inline bool Read1(uint8_t* v) WARNING_RESULT_NOT_USED { return Read(v); }
                                                                   ^
1 error generated.
    @VeithMetro
    VeithMetro authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0d0344c View commit details
    Browse the repository at this point in the history

  2. Add a PUSH_WARNING_ARG_

    @VeithMetro
    VeithMetro authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9ec2fe0 View commit details
    Browse the repository at this point in the history

  3. No need to build this repo with and without static linking

    @VeithMetro
    VeithMetro authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    214c6ff View commit details
    Browse the repository at this point in the history

  4. Remove the shared libs matrix in the workflow file

    @VeithMetro
    VeithMetro authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    45a8ba9 View commit details
    Browse the repository at this point in the history

  5. Add a separate logic for Read1(uint8_t) without the loop and shifting

    @VeithMetro
    VeithMetro authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    129a08f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Change the venv path to match the Linux templates

    @VeithMetro
    VeithMetro authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    237ada8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Use the workflows from master branches

    @VeithMetro
    VeithMetro authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    beb9b32 View commit details
    Browse the repository at this point in the history

  2. Checkout the master branch instead of develop

    @VeithMetro
    VeithMetro authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b2998bc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into development/actions-macos-release

    @VeithMetro
    VeithMetro authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8563866 View commit details
    Browse the repository at this point in the history