Skip to content

Conversation

@VeithMetro
Copy link
Contributor

@VeithMetro VeithMetro commented Jun 26, 2025

In the end, at the current state the plugin will not work without a proper Dropbear hack - making it build a library that we can link against. So in the future, it would probably be best to drop Dropbear entirely, and move towards a different method of managing the SSH connections

@VeithMetro VeithMetro requested a review from sebaszm June 26, 2025 13:02
Copilot AI review requested due to automatic review settings August 20, 2025 08:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes compilation errors and warnings in the SecureShellServer plugin. The main changes focus on correcting data type mismatches, updating method signatures, and improving the Dropbear library configuration.

  • Update JSON data structure references from SessioninfoResultData to GetactivesessionsinfoResultDataElem to match the API schema
  • Fix CMake configuration to properly link against static Dropbear libraries and dependencies
  • Add proper error handling for Dropbear service initialization

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
SecureShellServer/cmake/FindLibDropbear.cmake Updates CMake module to find static libraries and additional dependencies (libtomcrypt, libtommath)
SecureShellServer/SecureShellServerJsonRpc.cpp Updates JSON-RPC method signatures and data type conversions
SecureShellServer/SecureShellServer.h Updates header declarations to match new data types and fix const correctness
SecureShellServer/SecureShellServer.cpp Implements error handling for Dropbear initialization and updates data structure usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pwielders pwielders merged commit 2c0b320 into master Aug 21, 2025
48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2025
@VeithMetro VeithMetro deleted the development/secure-shell-sever-compile branch August 21, 2025 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants