Add PluginInitializerService plugin #910
Conversation
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
|
Cleared as this is non-blocking but the NOTICE file should get a credit to RDK Management by appending: |
Thanks for noticing, credit added in this PR now |
|
Thank you! |
of an if sometimes :) )
| class ActivationQueueInfo { | ||
| public: | ||
| ActivationQueueInfo(const TCHAR formatter[], ...) | ||
| { | ||
| va_list ap; | ||
| va_start(ap, formatter); | ||
| Core::Format(_text, formatter, ap); | ||
| va_end(ap); | ||
| } | ||
| explicit ActivationQueueInfo(const string& text) | ||
| : _text(Core::ToString(text)) | ||
| { | ||
| } | ||
| ~ActivationQueueInfo() = default; | ||
|
|
||
| ActivationQueueInfo(const ActivationQueueInfo&) = delete; | ||
| ActivationQueueInfo& operator=(const ActivationQueueInfo&) = delete; | ||
| ActivationQueueInfo(ActivationQueueInfo&&) = delete; | ||
| ActivationQueueInfo& operator=(ActivationQueueInfo&&) = delete; | ||
|
|
||
| public: | ||
| const char* Data() const | ||
| { | ||
| return (_text.c_str()); | ||
| } | ||
| uint16_t Length() const | ||
| { | ||
| return (static_cast<uint16_t>(_text.length())); | ||
| } | ||
|
|
||
| private: | ||
| std::string _text; | ||
| }; | ||
|
|
||
| class DetailedInfo { | ||
| public: | ||
| DetailedInfo(const TCHAR formatter[], ...) | ||
| { | ||
| va_list ap; | ||
| va_start(ap, formatter); | ||
| Core::Format(_text, formatter, ap); | ||
| va_end(ap); | ||
| } | ||
| explicit DetailedInfo(const string& text) | ||
| : _text(Core::ToString(text)) | ||
| { | ||
| } | ||
| ~DetailedInfo() = default; | ||
|
|
||
| DetailedInfo(const DetailedInfo&) = delete; | ||
| DetailedInfo& operator=(const DetailedInfo&) = delete; | ||
| DetailedInfo(DetailedInfo&&) = delete; | ||
| DetailedInfo& operator=(DetailedInfo&&) = delete; | ||
|
|
||
| public: | ||
| const char* Data() const | ||
| { | ||
| return (_text.c_str()); | ||
| } | ||
| uint16_t Length() const | ||
| { | ||
| return (static_cast<uint16_t>(_text.length())); | ||
| } | ||
|
|
||
| private: | ||
| std::string _text; | ||
| }; | ||
| } |
There was a problem hiding this comment.
There is macro to simplify this: DEFINE_MESSAGING_CATEGORY.
There was a problem hiding this comment.
Ah, thanks I did not know
| ActivateJob(ActivateJob&&) = delete; | ||
| ActivateJob& operator=(ActivateJob&&) = delete; | ||
|
|
||
| void Submit(const Core::ProxyType<Core::IDispatch>& job) |
There was a problem hiding this comment.
Aren't these methods missing interlocking?
There was a problem hiding this comment.
I think I gave that a good thought and seen the usage pattern (what can happen in parallel) this was safe. But I certainly see your point that at first it looks unexpected and ordering could lead to issues. It is too long ago to just remember, so let me double check and get back on this
No description provided.